Fallback to hwloc fetch if package not found #1185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
reviewed
Mar 13, 2025
PatKamin
force-pushed
the
hwloc-fallback
branch
from
97d296c to
fd44851
Compare
bratpiorka
approved these changes
Mar 14, 2025
KFilipek
reviewed
Mar 14, 2025
PatKamin
force-pushed
the
hwloc-fallback
branch
3 times, most recently
from
e48dfe5 to
42daf39
Compare
KFilipek
approved these changes
Mar 17, 2025
ldorau
approved these changes
Mar 17, 2025
Contributor
ldorau
left a comment
ldorau
left a comment
There was a problem hiding this comment.
@lukaszstolarczuk please verify and resolve all your issues
PatKamin
force-pushed
the
hwloc-fallback
branch
3 times, most recently
from
16ab7a1 to
55c2c9f
Compare
Fallback to fetching hwloc from source instead of failing UMF build. Add a workflow for testing the fallback. Unify correct paths to hwloc. Use target name instead of a library path for hwloc linkage.
PatKamin
force-pushed
the
hwloc-fallback
branch
from
55c2c9f to
a64565a
Compare
Contributor
|
@lukaszstolarczuk are you going to approve it? ;-) |
lukaszstolarczuk
approved these changes
Mar 18, 2025
Contributor
lukaszstolarczuk
left a comment
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
@lukaszstolarczuk are you going to approve it? ;-)
Needed to discuss something with @PatKamin yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallback to fetching hwloc from source instead of failing UMF build.
Add a workflow for testing the fallback.
Unify correct paths to hwloc.
Use target name instead of a library path for hwloc linkage.
To test examples, the
UMF_BUILD_EXAMPLESflag has to be set.Nightly run: https://github.com/PatKamin/unified-memory-framework/actions/runs/13916556000
Description
Checklist